Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to keep helm chart in sync with deploy manifest #305

Closed
leakingtapan opened this issue Jun 6, 2019 · 12 comments · Fixed by #475
Closed

Investigate how to keep helm chart in sync with deploy manifest #305

leakingtapan opened this issue Jun 6, 2019 · 12 comments · Fixed by #475

Comments

@leakingtapan
Copy link
Contributor

leakingtapan commented Jun 6, 2019

Is your feature request related to a problem? Please describe.
We created Helm chart for the driver here. Since we still have a deploy/kubernetes/manifest.yaml, this creates a problem about how to sync the two.

Describe the solution you'd like in detail
Potential solutions:

  • deprecate the deploy/kubernetes/manifest.yaml (not ideal)
  • Evaluate Kustomize
  • etc.

Additional Context

  • We have aws-alb-ingress-controler that is doing the same thing, I will check on that side how is this problem solved there.
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 4, 2019
@leakingtapan
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 4, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krmichel
Copy link
Contributor

krmichel commented Mar 1, 2020

/reopen

@k8s-ci-robot
Copy link
Contributor

@krmichel: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krmichel
Copy link
Contributor

krmichel commented Mar 1, 2020

@leakingtapan, I don't know if this has been dealt with, but I think that if helm template was used with a correct values file it could be used to create the base manifests. Then the helm chart could be maintained and Kustomize manifests could just synced by generating them from the chart. Thoughts?

@leakingtapan
Copy link
Contributor Author

leakingtapan commented Mar 2, 2020

/reopen
It’s a good idea :) would you be interested in helping on this?

@k8s-ci-robot k8s-ci-robot reopened this Mar 2, 2020
@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Reopened this issue.

In response to this:

/reopen
It’s a good idea :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krmichel
Copy link
Contributor

krmichel commented Mar 2, 2020

/remove-lifecycle rotten
Yeah, let me read up a little bit more on Kustomize and I will take a crack at it.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants