Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameters.md #1269

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

torredil
Copy link
Member

@torredil torredil commented Jun 8, 2022

Signed-off-by: Eddie Torres [email protected]

Is this a bug fix or adding new feature?

  • Update parameters.md

What is this PR about? / Why do we need it?

Signed-off-by: Eddie Torres <[email protected]>
@torredil torredil requested review from rdpsin and gtxu June 8, 2022 18:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@torredil torredil removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@torredil torredil removed the request for review from bertinatto June 8, 2022 18:01
@gtxu
Copy link
Contributor

gtxu commented Jun 8, 2022

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Jun 8, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@torredil
Copy link
Member Author

torredil commented Jun 8, 2022

/retest-required

@gtxu
Copy link
Contributor

gtxu commented Jun 8, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit feb53a3 into kubernetes-sigs:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants