Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mountOptions support #130

Merged

Conversation

bertinatto
Copy link
Member

Fixes #102.

/kind feature
/assign @leakingtapan

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 29, 2018
@bertinatto bertinatto changed the base branch from master to next November 29, 2018 13:40
@coveralls
Copy link

coveralls commented Nov 29, 2018

Pull Request Test Coverage Report for Build 199

  • 0 of 15 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 50.757%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/node.go 0 15 0.0%
Totals Coverage Status
Change from base Build 198: -0.5%
Covered Lines: 570
Relevant Lines: 1123

💛 - Coveralls

@bertinatto bertinatto changed the base branch from next to master December 3, 2018 10:26
@leakingtapan
Copy link
Contributor

leakingtapan commented Dec 6, 2018

@bertinatto Did you get a chance to test the change? Could you give some details on the testing? Other than this, LGTM.

@bertinatto
Copy link
Member Author

@leakingtapan, I created a volume using this storage class:

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: slow
  annotations:
    storageclass.kubernetes.io/is-default-class: "true"
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
parameters:
  fsType: ext4
mountOptions:
  - noexec

And I verified that the volume was mounted with the option noexec.

@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2018
@leakingtapan
Copy link
Contributor

We should add unit test for node service to improve the code coverage. Ref #142

Merge the PR to not block the feature

@leakingtapan leakingtapan merged commit 68069e9 into kubernetes-sigs:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants