Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve memory addresses in log messages #132

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

bertinatto
Copy link
Member

Fixes #74.

/kind bug
/assign @leakingtapan

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2018
@bertinatto bertinatto changed the base branch from master to next November 30, 2018 10:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2018
@coveralls
Copy link

coveralls commented Nov 30, 2018

Pull Request Test Coverage Report for Build 203

  • 2 of 17 (11.76%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 51.167%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/identity.go 0 3 0.0%
pkg/driver/controller.go 2 8 25.0%
pkg/driver/node.go 0 6 0.0%
Totals Coverage Status
Change from base Build 200: -0.1%
Covered Lines: 570
Relevant Lines: 1114

💛 - Coveralls

@bertinatto bertinatto closed this Nov 30, 2018
@bertinatto bertinatto reopened this Nov 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Nov 30, 2018
@leakingtapan
Copy link
Contributor

Do we have sample output to take a look?

@bertinatto
Copy link
Member Author

Sample line:

I1203 10:11:11.681529       1 controller.go:32] CreateVolume: called with args {Name:pvc-bad5f951-f6e3-11e8-a3bb-0ecf646fefd0 CapacityRange:required_bytes:4294967296  VolumeCapabilities:[mount:<fs_type:"ext4" mount_flags:"noexec" > access_mode:<mode:SINGLE_NODE_WRITER > ] Parameters:map[fsType:ext4] Secrets:map[] VolumeContentSource:<nil> AccessibilityRequirements:requisite:<segments:<key:"topology.ebs.csi.aws.com/zone" value:"us-east-1d" > > preferred:<segments:<key:"topology.ebs.csi.aws.com/zone" value:"us-east-1d" > >  XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}

@bertinatto bertinatto changed the base branch from next to master December 3, 2018 10:14
@bertinatto bertinatto mentioned this pull request Dec 3, 2018
@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2018
@leakingtapan
Copy link
Contributor

The drop is caused by extra lines of glog added.

@leakingtapan leakingtapan merged commit 9a17b67 into kubernetes-sigs:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants