Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-release v1.10.0 #1325

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Post-release v1.10.0 #1325

merged 2 commits into from
Jul 27, 2022

Conversation

torredil
Copy link
Member

Signed-off-by: Eddie Torres [email protected]

@torredil
Post-release v1.10.0
f6c2b16 
Signed-off-by: Eddie Torres <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@torredil torredil requested review from gtxu and removed request for wongma7 and AndyXiangLi July 27, 2022 18:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2022
gtxu
gtxu reviewed Jul 27, 2022
View reviewed changes
pkg/cloud/devicemanager/allocator.go
@@ -47,7 +47,9 @@ var _ NameAllocator = &nameAllocator{}

// GetNext gets next available device given existing names that are being used
// This function iterate through the device names in deterministic order of:
// ba, ... ,bz, ca, ... , cz
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that lint plugin add these empty line? Or an intentional formatting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, saw that update-gofm, lgtm

gtxu
gtxu approved these changes Jul 27, 2022
View reviewed changes
pkg/cloud/devicemanager/allocator.go
@@ -47,7 +47,9 @@ var _ NameAllocator = &nameAllocator{}

// GetNext gets next available device given existing names that are being used
// This function iterate through the device names in deterministic order of:
// ba, ... ,bz, ca, ... , cz
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, saw that update-gofm, lgtm

@torredil
Copy link
Member Author

CI is now using go1.19rc2...

$ docker run -it --rm --entrypoint /bin/sh gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220727-f055b40439-master
# go version
go version go1.19rc2 linux/amd64

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtxu, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@torredil
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@torredil: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gtxu
Copy link
Contributor

gtxu commented Jul 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 04442ca into kubernetes-sigs:release-1.10 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtxu gtxu gtxu approved these changes

Assignees

@gtxu gtxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torredil @k8s-ci-robot @gtxu