Add controller nodeAffinity to prefer EC2 over Fargate + Retrieve region/AZ from topology label in K8s #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
torredil
force-pushed
the
fargate-affinity
branch
3 times, most recently
from
a4e7af2
to
4f0275b
Compare
Signed-off-by: torredil <[email protected]>
torredil
force-pushed
the
fargate-affinity
branch
from
4f0275b
to
a6a7b09
Compare
k8s-ci-robot
added
size/M
torredil
changed the title
torredil
changed the title
torredil
force-pushed
the
fargate-affinity
branch
from
4aee3c5
to
7235013
Compare
torredil
changed the title
Signed-off-by: torredil <[email protected]>
torredil
force-pushed
the
fargate-affinity
branch
from
7235013
to
5012723
Compare
|
This looks pretty nice! |
torredil
removed
the
approved
|
@ConnorJC3: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? / Why do we need it?
preferredDuringSchedulingIgnoredDuringExecutionthe scheduler tries to find a node that meets the rule. If a matching node is not available, the scheduler still schedules the Pod.What testing is done?
make testSigned-off-by: Eddie Torres [email protected]