Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module k8s.io/klog to v2 #1370

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

torredil
Copy link
Member

@torredil torredil commented Sep 1, 2022

Is this a bug fix or adding new feature?

  • Bug fix.

What is this PR about? / Why do we need it?

What testing is done?

//current logging with --v=5

kubectl logs ebs-csi-node-5dfp2 -n kube-system -c ebs-plugin
I0901 00:11:25.194251       1 driver.go:73] Driver: ebs.csi.aws.com Version: v1.11.2
I0901 00:11:25.194302       1 node.go:96] [Debug] Retrieving node info from metadata service
I0901 00:11:25.194307       1 node.go:98] regionFromSession Node service
I0901 00:11:25.194319       1 metadata.go:85] retrieving instance data from ec2 metadata
W0901 00:11:28.364912       1 metadata.go:88] ec2 metadata is not available
I0901 00:11:28.364931       1 metadata.go:96] retrieving instance data from kubernetes api
I0901 00:11:28.369502       1 metadata.go:101] kubernetes api is available
I0901 00:11:28.385065       1 driver.go:143] Listening for connections on address: &net.UnixAddr{Name:"/csi/csi.sock", Net:"unix"}
I0901 00:11:28.848232       1 node.go:533] NodeGetInfo: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:13:31.591618       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:13:31.598301       1 node.go:119] NodeStageVolume: called with args {VolumeId:vol-0bc4f2e94e89e01cc PublishContext:map[devicePath:/dev/xvdba] StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/globalmount VolumeCapability:mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER >  Secrets:map[] VolumeContext:map[storage.kubernetes.io/csiProvisionerIdentity:1661991051451-8081-ebs.csi.aws.com] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:13:31.598409       1 node_linux.go:82] [Debug] Falling back to nvme volume ID lookup for: "/dev/xvdba"
I0901 00:13:31.598457       1 node_linux.go:95] [Debug] successfully resolved nvmeName="nvme-Amazon_Elastic_Block_Store_vol0bc4f2e94e89e01cc" to "/dev/nvme1n1"
I0901 00:13:31.598469       1 node.go:194] NodeStageVolume: find device path /dev/xvdba -> /dev/nvme1n1
I0901 00:13:31.598817       1 node.go:228] NodeStageVolume: formatting /dev/nvme1n1 and mounting at /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/globalmount with fstype ext4
I0901 00:13:31.626521       1 mount_linux.go:443] Disk "/dev/nvme1n1" appears to be unformatted, attempting to format as type: "ext4" with options: [-F -m0 /dev/nvme1n1]
I0901 00:13:31.981175       1 mount_linux.go:453] Disk successfully formatted (mkfs): ext4 - /dev/nvme1n1 /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/globalmount
I0901 00:13:32.032874       1 node.go:171] NodeStageVolume: volume="vol-0bc4f2e94e89e01cc" operation finished
I0901 00:13:32.032897       1 inflight.go:73] Node Service: volume="vol-0bc4f2e94e89e01cc" operation finished
I0901 00:13:32.038077       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:13:32.041927       1 node.go:373] NodePublishVolume: called with args {VolumeId:vol-0bc4f2e94e89e01cc PublishContext:map[devicePath:/dev/xvdba] StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/globalmount TargetPath:/var/lib/kubelet/pods/16b06431-97a2-496d-a0a6-425cdf44b0e9/volumes/kubernetes.io~csi/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/mount VolumeCapability:mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER >  Readonly:false Secrets:map[] VolumeContext:map[storage.kubernetes.io/csiProvisionerIdentity:1661991051451-8081-ebs.csi.aws.com] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:13:32.041990       1 node_linux.go:151] NodePublishVolume: creating dir /var/lib/kubelet/pods/16b06431-97a2-496d-a0a6-425cdf44b0e9/volumes/kubernetes.io~csi/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/mount
I0901 00:13:32.042076       1 node.go:709] NodePublishVolume: mounting /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/globalmount at /var/lib/kubelet/pods/16b06431-97a2-496d-a0a6-425cdf44b0e9/volumes/kubernetes.io~csi/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/mount with option [bind] as fstype ext4
I0901 00:13:32.050986       1 node.go:402] NodePublishVolume: volume="vol-0bc4f2e94e89e01cc" operation finished
I0901 00:13:32.051013       1 inflight.go:73] Node Service: volume="vol-0bc4f2e94e89e01cc" operation finished
I0901 00:14:14.324013       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:14:14.325880       1 node.go:454] NodeGetVolumeStats: called with args {VolumeId:vol-0bc4f2e94e89e01cc VolumePath:/var/lib/kubelet/pods/16b06431-97a2-496d-a0a6-425cdf44b0e9/volumes/kubernetes.io~csi/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/mount StagingTargetPath: XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:14:36.456053       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:14:36.457510       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:14:36.458984       1 node.go:304] NodeExpandVolume: called with args {VolumeId:vol-0bc4f2e94e89e01cc VolumePath:/var/lib/kubelet/pods/16b06431-97a2-496d-a0a6-425cdf44b0e9/volumes/kubernetes.io~csi/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/mount CapacityRange:required_bytes:8589934592  StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-8fbc2661-7b24-4ee0-9e2a-458abd20fb6d/globalmount VolumeCapability:mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER >  Secrets:map[] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0901 00:14:36.459680       1 node_linux.go:78] [Debug] The canonical device path for "/dev/nvme1n1" was resolved to: "/dev/nvme1n1"


//updated logging with --v=5

kubectl logs ebs-csi-node-l7h5q -n kube-system -c ebs-plugin
I0831 23:36:05.256149       1 driver.go:73] Driver: ebs.csi.aws.com Version: v1.11.2
I0831 23:36:05.256183       1 node.go:96] [Debug] Retrieving node info from metadata service
I0831 23:36:05.256192       1 node.go:98] regionFromSession Node service
I0831 23:36:05.256201       1 metadata.go:85] retrieving instance data from ec2 metadata
W0831 23:36:08.416398       1 metadata.go:88] ec2 metadata is not available
I0831 23:36:08.416411       1 metadata.go:96] retrieving instance data from kubernetes api
I0831 23:36:08.417334       1 metadata.go:101] kubernetes api is available
I0831 23:36:08.436894       1 mount_linux.go:207] Detected OS without systemd
I0831 23:36:08.437108       1 driver.go:143] Listening for connections on address: &net.UnixAddr{Name:"/csi/csi.sock", Net:"unix"}
I0831 23:36:09.490995       1 node.go:533] NodeGetInfo: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:44:46.164730       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:44:46.181531       1 node.go:119] NodeStageVolume: called with args {VolumeId:vol-04e07f8fead3c5190 PublishContext:map[devicePath:/dev/xvdba] StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount VolumeCapability:mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER >  Secrets:map[] VolumeContext:map[storage.kubernetes.io/csiProvisionerIdentity:1661988980628-8081-ebs.csi.aws.com] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:44:46.181852       1 node_linux.go:82] [Debug] Falling back to nvme volume ID lookup for: "/dev/xvdba"
I0831 23:44:46.181900       1 node_linux.go:95] [Debug] successfully resolved nvmeName="nvme-Amazon_Elastic_Block_Store_vol04e07f8fead3c5190" to "/dev/nvme1n1"
I0831 23:44:46.182313       1 node.go:194] NodeStageVolume: find device path /dev/xvdba -> /dev/nvme1n1
I0831 23:44:46.183160       1 node.go:228] NodeStageVolume: formatting /dev/nvme1n1 and mounting at /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount with fstype ext4
I0831 23:44:46.183322       1 mount_linux.go:481] Attempting to determine if disk "/dev/nvme1n1" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/nvme1n1])
I0831 23:44:46.236983       1 mount_linux.go:484] Output: ""
I0831 23:44:46.237022       1 mount_linux.go:443] Disk "/dev/nvme1n1" appears to be unformatted, attempting to format as type: "ext4" with options: [-F -m0 /dev/nvme1n1]
I0831 23:44:46.809025       1 mount_linux.go:453] Disk successfully formatted (mkfs): ext4 - /dev/nvme1n1 /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount
I0831 23:44:46.809171       1 mount_linux.go:471] Attempting to mount disk /dev/nvme1n1 in ext4 format at /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount
I0831 23:44:46.809209       1 mount_linux.go:182] Mounting cmd (mount) with arguments (-t ext4 -o defaults /dev/nvme1n1 /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount)
I0831 23:44:46.856041       1 mount_linux.go:481] Attempting to determine if disk "/dev/nvme1n1" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/nvme1n1])
I0831 23:44:46.865671       1 mount_linux.go:484] Output: "DEVNAME=/dev/nvme1n1\nTYPE=ext4\n"
I0831 23:44:46.865696       1 resizefs_linux.go:123] ResizeFs.needResize - checking mounted volume /dev/nvme1n1
I0831 23:44:46.877216       1 resizefs_linux.go:127] Ext size: filesystem size=4294967296, block size=4096
I0831 23:44:46.877232       1 resizefs_linux.go:139] Volume /dev/nvme1n1: device size=4294967296, filesystem size=4294967296, block size=4096
I0831 23:44:46.877239       1 node.go:171] NodeStageVolume: volume="vol-04e07f8fead3c5190" operation finished
I0831 23:44:46.877247       1 inflight.go:74] Node Service: volume="vol-04e07f8fead3c5190" operation finished
I0831 23:44:46.885809       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:44:46.905320       1 node.go:373] NodePublishVolume: called with args {VolumeId:vol-04e07f8fead3c5190 PublishContext:map[devicePath:/dev/xvdba] StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount TargetPath:/var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount VolumeCapability:mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER >  Readonly:false Secrets:map[] VolumeContext:map[storage.kubernetes.io/csiProvisionerIdentity:1661988980628-8081-ebs.csi.aws.com] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:44:46.905402       1 node_linux.go:151] NodePublishVolume: creating dir /var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount
I0831 23:44:46.905493       1 node.go:709] NodePublishVolume: mounting /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount at /var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount with option [bind] as fstype ext4
I0831 23:44:46.905508       1 mount_linux.go:182] Mounting cmd (mount) with arguments (-t ext4 -o bind /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount /var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount)
I0831 23:44:46.907297       1 mount_linux.go:182] Mounting cmd (mount) with arguments (-t ext4 -o bind,remount /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount /var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount)
I0831 23:44:46.913215       1 node.go:402] NodePublishVolume: volume="vol-04e07f8fead3c5190" operation finished
I0831 23:44:46.913237       1 inflight.go:74] Node Service: volume="vol-04e07f8fead3c5190" operation finished
I0831 23:45:14.315672       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:45:14.318712       1 node.go:454] NodeGetVolumeStats: called with args {VolumeId:vol-04e07f8fead3c5190 VolumePath:/var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount StagingTargetPath: XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:46:06.490722       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:46:06.491993       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:46:06.497168       1 node.go:304] NodeExpandVolume: called with args {VolumeId:vol-04e07f8fead3c5190 VolumePath:/var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount CapacityRange:required_bytes:8589934592  StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/globalmount VolumeCapability:mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER >  Secrets:map[] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:46:06.497795       1 node_linux.go:78] [Debug] The canonical device path for "/dev/nvme1n1" was resolved to: "/dev/nvme1n1"
I0831 23:46:06.497817       1 mount_linux.go:481] Attempting to determine if disk "/dev/nvme1n1" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/nvme1n1])
I0831 23:46:06.500237       1 mount_linux.go:484] Output: "DEVNAME=/dev/nvme1n1\nTYPE=ext4\n"
I0831 23:46:06.500253       1 resizefs_linux.go:55] ResizeFS.Resize - Expanding mounted volume /dev/nvme1n1
I0831 23:46:06.763942       1 resizefs_linux.go:70] Device /dev/nvme1n1 resized successfully
I0831 23:46:28.141252       1 node.go:517] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0831 23:46:28.143110       1 node.go:454] NodeGetVolumeStats: called with args {VolumeId:vol-04e07f8fead3c5190 VolumePath:/var/lib/kubelet/pods/58964bc2-ac3b-4eeb-a215-d3a371d5c232/volumes/kubernetes.io~csi/pvc-d3efa2d8-4829-48d4-9dd4-5a032ac6226f/mount StagingTargetPath: XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}

Signed-off-by: Eddie Torres [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Sep 1, 2022

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gtxu
Copy link
Contributor

gtxu commented Sep 2, 2022

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit b56e394 into kubernetes-sigs:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get klog.V(x) logs from k8s.io/mount-utils even cli flag --v=5 is set.
4 participants