Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm.sh/hook: test annotation to chart testing resources #1477

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add helm.sh/hook: test annotation to chart testing resources #1477

merged 1 commit into from
Jan 12, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Jan 12, 2023 •
edited
Loading

Is this a bug fix or adding new feature?

  • Bug fix.

What is this PR about? / Why do we need it?

What testing is done?

  • Manually validated that testing resources are not deployed.

Signed-off-by: Eddie Torres [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 12, 2023
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2023
@ConnorJC3 ConnorJC3 mentioned this pull request Jan 12, 2023
Closed
@rdpsin
Copy link
Contributor

rdpsin commented Jan 12, 2023

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2023
@torredil
Add helm.sh/hook: test annotation to chart testing resources
16ab52f 
Bugfix: Prevent deployment of testing resources during normal installation by adding `helm.sh/hook: test` annotation.

Signed-off-by: Eddie Torres <[email protected]>
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ConnorJC3 ConnorJC3 mentioned this pull request Jan 12, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 69015f5 into kubernetes-sigs:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@ConnorJC3 ConnorJC3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart v2.15.0 is creating testing resources during helm install
4 participants
@torredil @ConnorJC3 @rdpsin @k8s-ci-robot