Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CI k8s version to 1.26.1 (and other CI tools upgrades) #1487

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Bump CI k8s version to 1.26.1 (and other CI tools upgrades) #1487

merged 1 commit into from
Jan 19, 2023

Conversation

ConnorJC3
Copy link
Contributor

Signed-off-by: Connor Catlett [email protected]

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2023
@ConnorJC3
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2023
@ConnorJC3 ConnorJC3 changed the title Bump CI k8s version to 1.26 (and other CI tools upgrades) Bump CI k8s version to 1.26.1 (and other CI tools upgrades) Jan 18, 2023
@ConnorJC3
Copy link
Contributor Author

/test all

@ConnorJC3
Copy link
Contributor Author

ConnorJC3 commented Jan 18, 2023 •
edited
Loading

Undrafting because 1.26.1 is now available for testing against.

@ConnorJC3 ConnorJC3 marked this pull request as ready for review January 18, 2023 21:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
torredil
torredil reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also bump up:

Other than that, lgtm, thanks 👍

torredil
torredil approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit d1bd99e into kubernetes-sigs:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@rdpsin rdpsin Awaiting requested review from rdpsin

@gtxu gtxu Awaiting requested review from gtxu

Assignees

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConnorJC3 @k8s-ci-robot @torredil