Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable volume modification through annotations #1600

Merged
merged 1 commit into from
May 15, 2023
Merged

Enable volume modification through annotations #1600

merged 1 commit into from
May 15, 2023

Conversation

rdpsin
Copy link
Contributor

@rdpsin rdpsin commented May 15, 2023

The commit allows users to modify volume properties through PVC annotations. For more details, refer to the modify-volume doc.

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2023
@torredil
Copy link
Member

/retest

1 similar comment
@rdpsin
Copy link
Contributor Author

rdpsin commented May 15, 2023

/retest

@ConnorJC3
Copy link
Contributor

/retest

ConnorJC3
ConnorJC3 approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term, we should have unit/e2e tests for this, but otherwise lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@rdpsin
Enable volume modification through annotations
1560d54 
The commit allows users to modify volume properties through PVC
annotations. For more details, refer to the modify-volume doc.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@ConnorJC3
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@rdpsin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows 1560d54 link false /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rdpsin
Copy link
Contributor Author

rdpsin commented May 15, 2023

/retest

@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@torredil
Copy link
Member

/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

@k8s-ci-robot k8s-ci-robot merged commit d47ee59 into kubernetes-sigs:master May 15, 2023
@kon-angelo kon-angelo mentioned this pull request May 25, 2023
Merged
@mpatlasov mpatlasov mentioned this pull request Aug 23, 2023
Closed
@jsafrane jsafrane mentioned this pull request Nov 21, 2023
Merged
@rifelpet rifelpet mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 approved these changes

@torredil torredil torredil approved these changes

Assignees

@ConnorJC3 ConnorJC3

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdpsin @torredil @ConnorJC3 @k8s-ci-robot