Handle deleted Node case in hook; Add support for CAS taint #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Code Coverage Diff
|
k8s-ci-robot
added
the
lgtm
AndrewSirenko
approved these changes
Apr 12, 2024
Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
prestop-when-node-is-dead
branch
from
086c264
to
79dd7af
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 12, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
Handle deleted Node case in hook
When the
Nodeobject does not exist, the existing hook returns an error. Instead, in this case, assume the node is being drained and proceed with the hook. Partially solves #1955Add support for CAS taint
Similar to Karpenter,
cluster-autoscalerhas its own custom taint it uses when draining nodes. Add it to the hook's drain detection logic.What testing is done?
Manual/CI