Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile & hack/ Process Improvements #2028

Merged
merged 6 commits into from
May 2, 2024

Conversation

ConnorJC3
Copy link
Contributor

@ConnorJC3 ConnorJC3 commented Apr 30, 2024

Is this a bug fix or adding new feature?

"New Feature"

What is this PR about? / Why do we need it?

This PR is split into several much smaller commits:

Move WINDOWS and WINDOWS_HOSTPROCESS out of Makefile to correct location in config.sh
Small fix to remove unnecessary variables in the Makefile.

Use Prow BUILD_ID in CI jobs if present to greatly reduce the chance of cluster name collisions in CI
Prow jobs have a random chance of colliding because $RANDOM is only a 4 digit number (You'd think it's 1/10000 but it's much higher than that because of the Birthday Paradox).

Use $BUILD_ID in CI which is guaranteed to be unique. Had to cut off a little bit of the beginning of the name to make it short enough for eksctl.

Add make cluster/kubeconfig
Convenience command for local development, used to set the KUBECONFIG for the cluster created by make cluster/create.

Add make cluster/image command; Build image and cluster in parallel for CI
Parallelize building the image and creating the cluster on CI, had to split image build out into a separate command to do this.

Breaking change for contributors: make cluster/e2e style commands no longer build the image, you must either run make cluster/image first or bring your own image.

Template eksctl cluster file so Windows nodegroup can build in parallel
Parallelize creating the Linux and Windows nodegroup for eksctl clusters by using a cluster file instead of eksctl commands.

Parallelize kubetest2 installation in CI
kubetest2 takes surprisingly long to install, might as well do so while building the cluster/image already.

What testing is done?
CI/Manual

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3 ConnorJC3 force-pushed the faster-clusters branch 2 times, most recently from e070430 to 86e1f46 Compare April 30, 2024 19:57
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all great quality of life improvements. Thank you for saving hours of time over the next year.

hack/tools/install.sh Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AndrewSirenko
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 09ce01b into kubernetes-sigs:master May 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants