Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot examples #210

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Add snapshot examples #210

merged 1 commit into from
Feb 18, 2019

Conversation

tsmetana
Copy link
Contributor

Added external snapshotter to the controller yaml, updated readme and deployment example.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2019
@coveralls
Copy link

coveralls commented Feb 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 449

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.814%
Totals Coverage Status
Change from base Build 425: 0.0%
Covered Lines: 917
Relevant Lines: 1437
💛 - Coveralls

leakingtapan
leakingtapan reviewed Feb 13, 2019
View reviewed changes
Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README is optional for this PR. We can add it later

deploy/kubernetes/controller.yaml Outdated
@@ -23,6 +23,18 @@ rules:
- apiGroups: [""]
resources: ["events"]
verbs: ["get", "list", "watch", "create", "update", "patch"]
- apiGroups: ["snapshot.storage.k8s.io"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a separate clusterrole just for snapshotter, and tie it with the csi-controller-sa service account. Refer to https://github.com/kubernetes-csi/external-snapshotter/blob/01bd7f356e6718dee87914232d287631655bef1d/deploy/kubernetes/rbac.yaml

examples/kubernetes/volume_scheduling/snapshot.yaml Outdated
@@ -0,0 +1,9 @@
apiVersion: snapshot.storage.k8s.io/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a separate dir snapshot under examples/kubernetes with all the necessary manifest files just for this use case? I am trying to modularize the examples so that user can just pick whichever example they care about. It will be great if you also add some README.md under the snapshot dir with some instructions about how to execute the example.

@leakingtapan
Copy link
Contributor

/cc @dkoshkin

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2019
@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3e2563b into kubernetes-sigs:snapshot Feb 18, 2019
This was referenced Feb 18, 2019
Closed
Merged
dobsonj pushed a commit to dobsonj/aws-ebs-csi-driver that referenced this pull request Oct 17, 2023
@openshift-merge-robot
Merge pull request kubernetes-sigs#210 from openshift-cherrypick-robo…
2bad4b4 
…t/cherry-pick-209-to-release-4.10

[release-4.10] OCPBUGS-1804: UPSTREAM: 1398: Add resolver to handle custom endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@jsafrane jsafrane Awaiting requested review from jsafrane

@dkoshkin dkoshkin Awaiting requested review from dkoshkin

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsmetana @coveralls @leakingtapan @k8s-ci-robot