Add local snapshots on outposts

[ElijahQuinones]

Is this a bug fix or adding new feature?

fixes #2087

What is this PR about? / Why do we need it?

This PR will allow customers to pass the outpost ARN as a parameter to the VSC.
This will enable customers to have local snapshots saved onto S3 on their outpost and not just in S3 on the region their outpost is in.

What testing is done?

This is currently being tested in outpost.

[k8s-ci-robot]

Hi @ElijahQuinones. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[torredil]

/ok-to-test

[ElijahQuinones]

/hold

[ElijahQuinones]

/retest

[rdpsin]

Can we also add this option to the docs? I don't see any VSC parameters doc, maybe this a good opportunity to create one.

[ElijahQuinones]

/unhold

[ElijahQuinones]

Tested In outpost and confirmed we are now able to have local snapshots in outpost.

Type    Reason            Age   From                 Message
  ----    ------            ----  ----                 -------
  Normal  CreatingSnapshot  11m   snapshot-controller  Waiting for a snapshot default/ebs-volume-snapshot to be created by the CSI driver.
  Normal  SnapshotCreated   11m   snapshot-controller  Snapshot default/ebs-volume-snapshot was successfully created by the CSI driver.
  Normal  SnapshotReady     9m9s  snapshot-controller  Snapshot default/ebs-volume-snapshot is ready to use.

For testing I used the following VSC

apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
  name: csi-aws-vsc
driver: ebs.csi.aws.com
deletionPolicy: Delete
parameters:
  outpostarn: {arn of our outpost}

[torredil]

Thanks for manually testing. Changes largely look good to me, will re-review once this thread is resolved: #2130 (review).

[ConnorJC3]

lgtm, would like to test this manually before I approve, but no issues spotted reading the code

[ConnorJC3]

Needs squash otherwise lgtm

Tested and confirmed I can create a snapshot bound to a specific outpost:

[AndrewSirenko]

/lgtm

[torredil]

/label tide/merge-method-squash
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment