Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ControllerPublish and ControllerUnpublish requests #219

Merged

Conversation

sreis
Copy link
Contributor

@sreis sreis commented Feb 19, 2019

Is this a bug fix or adding new feature?

Increases test coverage.

What is this PR about? / Why do we need it?

Increases test coverage.

Closes #199

What testing is done?

Add unit tests for ControllerPublish and ControllerUnpublish requests.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sreis. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2019
@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2019
@leakingtapan
Copy link
Contributor

travis is having issue these days:

{"message":"Couldn't find a repository matching this job.","error":true}
The command "$GOPATH/bin/goveralls -coverprofile=profile.cov -service=travis-ci" exited with 1.

@sreis sreis force-pushed the sreis/controller-unit-tests branch from b270436 to e522feb Compare February 19, 2019 17:37
@coveralls
Copy link

coveralls commented Feb 20, 2019

Pull Request Test Coverage Report for Build 462

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.4%) to 67.84%

Totals Coverage Status
Change from base Build 461: 3.4%
Covered Lines: 983
Relevant Lines: 1449

💛 - Coveralls

@leakingtapan
Copy link
Contributor

@sreis could you rebase. thx

@sreis sreis force-pushed the sreis/controller-unit-tests branch from e522feb to ce54c5d Compare February 21, 2019 09:54
@sreis
Copy link
Contributor Author

sreis commented Feb 21, 2019

@leakingtapan I've rebased PTAL.

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, sreis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 14b4f96 into kubernetes-sigs:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Unit Test for ControllerPublishVolume and ControllerUnpublishVolume
4 participants