Refactor controller unit test with proper mock

[zacharya]

Is this a bug fix or adding new feature?
Refactor Cloud interface unit tests to use GoMock

What is this PR about? / Why do we need it?

• Addresses Refactor controller unit test with proper mock #220 .
• One thing to discuss - moving cloud.FakeCloudProvider to sanity.fakeCloudProvider required exporting cloud.metadata due to the dependency. I don't see any issues with this, but I figured I'd bring it up in case some of the maintainers see problems.

What testing is done?
Both make test and make test-sanity are running fine.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zacharya
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ddebroy

If they are not already assigned, you can assign the PR to them by writing /assign @ddebroy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @zacharya. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 577

• 22 of 26 (84.62%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+4.9%) to 70.042%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/driver/fakes.go	0	1	0.0%
pkg/driver/controller.go	12	15	80.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/driver/controller.go	1	66.77%

Totals
Change from base Build 575:	4.9%
Covered Lines:	996
Relevant Lines:	1422

---

💛 - Coveralls