Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor device path allocator #274

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Refactor device path allocator #274

merged 1 commit into from
Apr 11, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Apr 7, 2019 •
edited
Loading

Is this a bug fix or adding new feature?
Simplify device name allocator logic:

  • using deterministic algorithm to generate device name
  • the device names are generated in order of: a, b, ..., z, aa, ab, ..., az

Fixes: #35

/cc @bertinatto

What testing is done?
Verified creating 60 volumes on a 2 node cluster.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2019
@coveralls
Copy link

coveralls commented Apr 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 595

  • 20 of 21 (95.24%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 69.27%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/devicemanager/manager.go 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
pkg/cloud/devicemanager/manager.go 5 84.21%
Totals Coverage Status
Change from base Build 594: -1.1%
Covered Lines: 958
Relevant Lines: 1383
💛 - Coveralls

@leakingtapan leakingtapan merged commit d94c30d into kubernetes-sigs:master Apr 11, 2019
@leakingtapan leakingtapan deleted the device-manager branch April 11, 2019 22:23
@tsmetana tsmetana mentioned this pull request May 7, 2019
Closed
dobsonj pushed a commit to dobsonj/aws-ebs-csi-driver that referenced this pull request Sep 10, 2024
@openshift-merge-bot
Merge pull request kubernetes-sigs#274 from mpatlasov/OCPBUGS-37088-f…
8ab84ff 
…ix-allocatable-volumes-count-for-vt1-and-g4

OCPBUGS-37088: UPSTREAM: 2108, 2115: Fix allocatable volumes count for vt1 and g4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Cache Implementation
3 participants
@leakingtapan @k8s-ci-robot @coveralls