Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output junit to ARTIFACTS for testgrid #340

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 12, 2019

Is this a bug fix or adding new feature? fix

What is this PR about? / Why do we need it? test-grid should have tests separated by testcase instead of just Overall

fix #192

What testing is done? wait for the test to complete for this PR and check test-grid

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 13, 2019

doesn't seem to work. i think ginkgo is eating the report-dir arg? In EFS, I don't call ginkgo I call go test.

@leakingtapan
Copy link
Contributor

leakingtapan commented Aug 13, 2019

doesn't seem to work. i think ginkgo is eating the report-dir arg? In EFS, I don't call ginkgo I call go test.

The report-dir flag is bring in as flag by framework.HandleFlags(), which you added in EFS e2e

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 13, 2019

Got it, need to put non-ginkgo args after --. (We have framework.handleflags already.)

To pass arguments/custom flags down to your test suite:

$ ginkgo -- <PASS-THROUGHS>

Note: the -- is important! Only arguments following -- will be passed to your suite. To parse arguments/custom flags in your test suite, declare a variable and initialize it at the package-level:

https://onsi.github.io/ginkgo/#running-tests

@leakingtapan
Copy link
Contributor

/retest

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@leakingtapan
Copy link
Contributor

override the failure since coverall is having issue. And this only impact out test coverage

@leakingtapan leakingtapan merged commit 8d8dc6a into kubernetes-sigs:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report test result as independent test case in Testgrid for E2E tests
3 participants