[helm] add tag options and update csi-provisioner

[kcking]

Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Add options to create EBS volume tags that the in-tree plugin creates
What testing is done?
Tested within our EKS 1.17 cluster, confirmed that new volumes have correct names/tags.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @kcking!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kcking. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 1262

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 81.134%

---

Totals
Change from base Build 1249:	0.0%
Covered Lines:	1574
Relevant Lines:	1940

---

💛 - Coveralls

[kcking]

Check CLA again

[leakingtapan]

/ok-to-test
Could you update the chat version as well?

[kcking]

Sure thing, just bumped it to 0.6.1

[jwesolowski-rms]

@kcking this looks great. @leakingtapan Is it possible to get this merged in assuming all looks fine to you?

[jwesolowski-rms]

Whoops. Just saw one thing. @kcking for consistency, I'm thinking adding the new k8sTagClusterId and extraCreateMetadata values to the values.yaml with a default and comment would be helpful. This would be similar to what we have for enableVolumeScheduling.

[kcking]

Sure thing. I'm thinking a default of kubernetes for k8sTagClusterId as I think the in-tree plugin creates volumes with a prefix of kubernetes. Alternatively we could not specify by default but leave it defined in a comment

Then should we default extraCreateMetadata to true or false?

[jwesolowski-rms]

I think I would lean towards mimicking the defaults in the controller and csi-provisioner itself:

• k8sTagClusterId defaults to "" (link)
• extraCreateMetadata defaults to false (link)

[kcking]

@jwesolowski-rms thank you for the links! Just added them

[jwesolowski-rms]

@kcking thanks for the modifications! Looks perfect.

[jwesolowski-rms]

@leakingtapan any update on this?

[leakingtapan]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kcking, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [leakingtapan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment