Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suffix amazonlinux image with -amazonlinux and push debian image to GitHub #639

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 7, 2020

**Is this a bug fix or adding new feature?**fix

**What is this PR about? / Why do we need it?**To match cloudbuild.yaml https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/cloudbuild.yaml and in preparation for the next release v0.8.0, amazonlinux based images will be suffixed with -amazonlinux, like v0.8.0-amazonlinux. And debian based images will become the "default" unsuffixed v0.8.0.

At the same time, I noticed crazy-max/ghaction-docker-buildx@v3 was deprecated https://github.com/crazy-max/ghaction-docker-buildx so I rewrote the action to use docker's official github actions.

What testing is done? Not sure if testing is possible? given the extensive rewrite I want to test the new scrijpt but it doesn't seem possible without actually triggering the action. So I will check if the latest tag was successfully pushed after this PR and if not will need a follow-up...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2020
@wongma7 wongma7 changed the title Suffix amazonlinux image with -amazonlinux and push debian image to GitHub WIP: Suffix amazonlinux image with -amazonlinux and push debian image to GitHub Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2020
@wongma7 wongma7 changed the title WIP: Suffix amazonlinux image with -amazonlinux and push debian image to GitHub Suffix amazonlinux image with -amazonlinux and push debian image to GitHub Dec 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2020
run: |
DEB_PUSH_TAG="docker.pkg.github.com/$GITHUB_REPOSITORY/$IMAGE:$TAG"
docker buildx build \
-t $DEB_PUSH_TAG \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this uses the cache from previous build step ($DEB_BUILD_TAG) . If not, there is no point to $DEB_BUILD_TAG/ $AL2_BUILD_TAG

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm a little bit confused. What's the benefit of build steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes it quicker to debug what failed. if build succeed but push step failed. etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from local testing the build step image is cached so IMO it makes sense to separate the two steps

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%

Totals Coverage Status
Change from base Build 1338: 0.0%
Covered Lines: 1622
Relevant Lines: 1985

💛 - Coveralls

@ayberk
Copy link
Contributor

ayberk commented Dec 7, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ayberk: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nckturner
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Dec 8, 2020

I don't have permission to restart travis CI, but it is unrelated and not required for merge so I am manually merging.

@wongma7 wongma7 merged commit 32bb691 into kubernetes-sigs:master Dec 8, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Dec 8, 2020

The arm build fails, I'll figure it out and send follow up

2020-12-08T18:34:29.7913665Z #8 [linux/arm64 debian-base 2/3] RUN clean-install ca-certificates e2fsprog...
2020-12-08T18:34:29.7914574Z #8 9.250 standard_init_linux.go:219: exec user process caused: exec format error
2020-12-08T18:34:29.9412982Z #8 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants