Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add well-known topology label #773

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Mar 2, 2021

Is this a bug fix or adding new feature?
Feature

What is this PR about? / Why do we need it?
See #729. This is the first part where we start writing the label and also give priority to it when reading topology labels. This change is completely backward-compatible with no change in behavior as far as users are concerned.

What testing is done?
Unit tests
Single AZ e2e (there was one failed case that should be unrelated, probably flake)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2021
@ayberk
Copy link
Contributor Author

ayberk commented Mar 2, 2021

/assign @wongma7
/assign @AndyXiangLi

@k8s-ci-robot
Copy link
Contributor

@ayberk: GitHub didn't allow me to assign the following users: AndyXiangLi.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wongma7
/assign @AndyXiangLi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -41,11 +41,14 @@ const (

const (
DriverName = "ebs.csi.aws.com"
TopologyKey = "topology." + DriverName + "/zone"
AwsPartitionKey = "topology." + DriverName + "/partition"
AwsAccountIDKey = "topology." + DriverName + "/account-id"
AwsRegionKey = "topology." + DriverName + "/region"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we deprecate the region one as well? It seems like we only set it in the outposts case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm makes sense yeah. I didn't include it because as you said we only use it internally, but that would be more future-proof.

@coveralls
Copy link

coveralls commented Mar 2, 2021

Pull Request Test Coverage Report for Build 1728

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 81.789%

Totals Coverage Status
Change from base Build 1714: 0.09%
Covered Lines: 1756
Relevant Lines: 2147

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2021
@AndyXiangLi
Copy link
Contributor

LGTM, let's wait for another approval :-)

@wongma7
Copy link
Contributor

wongma7 commented Mar 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 12, 2021

sorry I think you have to rebase since I moved some stuff to node_linux.go ...

@wongma7
Copy link
Contributor

wongma7 commented Mar 12, 2021


pkg/driver/node.go:27:2: imported and not used: "golang.org/x/sys/unix"
pkg/driver/node.go:36:2: volume redeclared as imported package name
	previous declaration at pkg/driver/node.go:28:2 

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 56ea42c into kubernetes-sigs:master Mar 13, 2021
@ayberk ayberk deleted the ga_label branch March 13, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants