Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toleration time to NoExecute effect --- Enable in next release #776

Merged

Conversation

AndyXiangLi
Copy link
Contributor

@AndyXiangLi AndyXiangLi commented Mar 4, 2021

Continue from #775
Is this a bug fix or adding new feature?
Fixes #588
What is this PR about? / Why do we need it?
Not tolerate NoSchedule effect and add default 300s tolerationSeconds to all the NoExecute taints.

As we discussed, will default to tolerateAllTaints for now, will disable this in next release.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2021
@coveralls
Copy link

coveralls commented Mar 4, 2021

Pull Request Test Coverage Report for Build 1677

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.712%

Totals Coverage Status
Change from base Build 1676: 0.0%
Covered Lines: 1747
Relevant Lines: 2138

💛 - Coveralls

@@ -70,7 +70,7 @@ resources:

priorityClassName: ""
nodeSelector: {}
tolerateAllTaints: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we should change the default but unsure if it's "safe" by helm standards to do it in a point release.

wdyt @ayberk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this should be mostly fine, but it might still break the existing workflow for some customers with basically no heads-up.

I'd rather change the behavior with a release so we can at least have a note in the release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, How about we keep the current behavior for now, and turn this flag off in the next release(which should be pretty soon)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@vdhanan vdhanan mentioned this pull request Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2021
@AndyXiangLi AndyXiangLi changed the title add toleration time to NoExecute effect add toleration time to NoExecute effect --- Enable in next release Mar 5, 2021
@ayberk
Copy link
Contributor

ayberk commented Mar 5, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi, ayberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ee3b46c into kubernetes-sigs:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tolerationSeconds for tolerations for controller
5 participants