Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging for outpost arn handling #851

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Apr 23, 2021

We recently encountered a case where driver wouldn't use the outpost arn despite metadata being available. I'm adding more logging around it to help troubleshooting the issue in the future.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1888

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.534%

Totals Coverage Status
Change from base Build 1886: 0.02%
Covered Lines: 1899
Relevant Lines: 2358

💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Apr 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@ayberk
Copy link
Contributor Author

ayberk commented Apr 23, 2021

/retest

return nil, fmt.Errorf("something went wrong while getting EC2 outpost arn")
return nil, fmt.Errorf("something went wrong while getting EC2 outpost arn: %s", err.Error())
} else if err == nil {
klog.Infof("Running in an outpost environment with arn: %s", outpostArn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you set the log level to 5 for these two log statements.
Want to make every log explicitly set with a level, so later we can filter the log by their level.

@k8s-ci-robot k8s-ci-robot merged commit aa83722 into kubernetes-sigs:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants