Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup helm chart #856

Merged
merged 1 commit into from
May 24, 2021
Merged

Cleanup helm chart #856

merged 1 commit into from
May 24, 2021

Conversation

krmichel
Copy link
Contributor

@krmichel krmichel commented Apr 28, 2021 •
edited
Loading

Is this a bug fix or adding new feature?
Fixes #448
Fixes #512
Fixes #672
Fixes #722
Fixes #746
Fixes #758
Fixes #797
Fixes #887

What is this PR about? / Why do we need it?
Cleaning up and adding functionality to the helm chart

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @krmichel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 28, 2021
@krmichel
Copy link
Contributor Author

@ayberk or @wongma7 Please check out this PR and provide an ok to test

@coveralls
Copy link

coveralls commented Apr 28, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1987

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.125%
Totals Coverage Status
Change from base Build 1984: 0.0%
Covered Lines: 1990
Relevant Lines: 2515
💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Apr 28, 2021

/ok-to-test

Iw ill be busy next 2 weeks but try my best to review before then.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
wongma7
wongma7 reviewed Apr 28, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2021
@krmichel krmichel requested a review from wongma7 April 29, 2021 12:58
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021
wongma7
wongma7 reviewed May 18, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@krmichel krmichel mentioned this pull request May 19, 2021
Closed
@AndyXiangLi AndyXiangLi mentioned this pull request May 19, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2021
@wongma7
Copy link
Contributor

wongma7 commented May 21, 2021

/lgtm

/approve

I think the rebase is just the chart version. let's get merged asap to avoid more rebasing pain ..

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@wongma7 wongma7 mentioned this pull request May 21, 2021
Closed
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 22, 2021
@krmichel
Copy link
Contributor Author

/lgtm

/approve

I think the rebase is just the chart version. let's get merged asap to avoid more rebasing pain ..

@wongma7 I have rebased and the tests are running.

@krmichel
Copy link
Contributor Author

@wongma7 The tests are passed just needs a /lgtm

@wongma7
Copy link
Contributor

wongma7 commented May 24, 2021

/lgtm

thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit f5b404b into kubernetes-sigs:master May 24, 2021
@krmichel krmichel mentioned this pull request May 26, 2021
Merged
@krmichel krmichel mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@AndyXiangLi AndyXiangLi AndyXiangLi left review comments

@ayberk ayberk Awaiting requested review from ayberk

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@krmichel @k8s-ci-robot @coveralls @wongma7 @AndyXiangLi