fix naming mistake in clusterrolebinding, expose env var to controller via downward api

[vdhanan]

Is this a bug fix or adding new feature?
fix
What is this PR about? / Why do we need it?
fixes naming mistake
What testing is done?
manually testing now, will finish before merging

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdhanan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdhanan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdhanan]

/hold

[coveralls]

Pull Request Test Coverage Report for Build 1951

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 79.188%

---

Totals
Change from base Build 1949:	0.0%
Covered Lines:	1990
Relevant Lines:	2513

---

💛 - Coveralls

[AndyXiangLi]

/lgtm
Can you also cherry-pick this change to v1.0.0 branch?

[vdhanan]

Disabled instance metadata with the following command:

➜  aws-ebs-csi-driver git:(master) ✗ aws ec2 modify-instance-metadata-options \    --instance-id i-06b71b5a49302390b \                                  
    --http-endpoint disabled

Then deployed the driver, verified csi controller and nodes are running:

➜  aws-ebs-csi-driver git:(master) ✗ kubectl get pods -n kube-systemNAME                                  READY   STATUS    RESTARTS   AGEaws-node-4p4rc                        1/1     Running   0          66d
aws-node-h6qwh                        1/1     Running   0          66d
aws-node-jqk6j                        1/1     Running   0          66d
coredns-559b5db75d-4cggs              1/1     Running   0          66d
coredns-559b5db75d-f8pgl              1/1     Running   0          66d
ebs-csi-controller-85d7fcfd88-2q6wk   6/6     Running   0          29s
ebs-csi-controller-85d7fcfd88-ss8ml   6/6     Running   0          29s
ebs-csi-node-9x8k6                    3/3     Running   0          29s
ebs-csi-node-l9bq8                    3/3     Running   0          29s
ebs-csi-node-rcz5n                    3/3     Running   0          29s
ebs-snapshot-controller-0             1/1     Running   0          29s
kube-proxy-987lz                      1/1     Running   0          66d
kube-proxy-tnbkt                      1/1     Running   0          66d
kube-proxy-z2vzx                      1/1     Running   0          66d

Checked logs for further verification. I added the EC2 instance metadata is not available log, so I'm now positive that the new code path is being exercised:

➜  aws-ebs-csi-driver git:(master) ✗ kubectl logs -n kube-system -c ebs-plugin ebs-csi-controller-85d7fcfd88-2q6wk
I0511 19:27:43.767633       1 driver.go:72] Driver: ebs.csi.aws.com Version: v1.0.0
I0511 19:27:43.767687       1 controller.go:80] [Debug] Retrieving region from metadata service
W0511 19:27:44.030811       1 metadata.go:98] EC2 instance metadata is not available
I0511 19:27:44.044990       1 driver.go:142] Listening for connections on address: &net.UnixAddr{Name:"/var/lib/csi/sockets/pluginproxy/csi.sock", Net:"unix"}
I0511 19:27:44.217135       1 controller.go:360] ControllerGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0511 19:27:44.218374       1 controller.go:360] ControllerGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0511 19:27:44.997351       1 controller.go:360] ControllerGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0511 19:27:45.996488       1 controller.go:360] ControllerGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I0511 19:27:47.669940       1 controller.go:360] ControllerGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}

Checked that the deployment succeeds with both helm and kustomize.

[wongma7]

nice, thanks!!

/lgtm

[vdhanan]

/unhold