Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump chart-releaser-action to v1.2.1 #914

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Bump chart-releaser-action to v1.2.1 #914

merged 1 commit into from
Jun 3, 2021

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Jun 1, 2021

Signed-off-by: Gábor Lipták [email protected]

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot
Copy link
Contributor

Hi @gliptak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2015

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.125%
Totals Coverage Status
Change from base Build 2012: 0.0%
Covered Lines: 1990
Relevant Lines: 2515
💛 - Coveralls

@gliptak
Copy link
Contributor Author

gliptak commented Jun 1, 2021

/assign @vdhanan

@vdhanan
Copy link
Contributor

vdhanan commented Jun 1, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2021
@vdhanan
Copy link
Contributor

vdhanan commented Jun 1, 2021

/retest

@vdhanan
Copy link
Contributor

vdhanan commented Jun 2, 2021

could you please explain why we should upgrade to 1.2.1?

@gliptak
Copy link
Contributor Author

gliptak commented Jun 2, 2021

@vdhanan regular care&feeding

@vdhanan
Copy link
Contributor

vdhanan commented Jun 2, 2021

fair enough. comparing the two versions, it seems like a trivial upgrade.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gliptak, vdhanan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@wongma7
Copy link
Contributor

wongma7 commented Jun 3, 2021

/test pull-aws-ebs-csi-driver-migration-test

@k8s-ci-robot k8s-ci-robot merged commit a2a1b1f into kubernetes-sigs:master Jun 3, 2021
@gliptak gliptak deleted the patch-1 branch June 3, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyXiangLi AndyXiangLi Awaiting requested review from AndyXiangLi

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@vdhanan vdhanan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gliptak @k8s-ci-robot @coveralls @vdhanan @wongma7