Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.3 #992

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Release 1.1.3 #992

merged 1 commit into from
Jul 27, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 24, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
cherry-picking helm/doc changes from release-1.1 branch to master.

we released 1.1.2 with base image changes for cve, and then 1.1.3 right after cuz of an issue with the ECR build.

/hold
What testing is done?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 24, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jul 24, 2021

/hold cancel

nvm.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2021
@@ -20,6 +20,7 @@ RUN make
FROM amazonlinux:2 AS amazonlinux
Copy link

@SaranBalaji90 SaranBalaji90 Jul 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline using https://hub.docker.com/r/amd64/amazonlinux/ and arm64v8 reduces image size significantly (from 750MB to 250MB). We should move to that instead of using amazonlinux:2

@RCarretta
Copy link

we released 1.1.2 with base image changes for cve, and then 1.1.3 right after cuz of an issue with the ECR build.

Hey, could you check #993 ?

@nckturner
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fce0b66 into kubernetes-sigs:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants