-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow controller SA to describe Secrets - fixes cross account dynamic provisioning #1256
Allow controller SA to describe Secrets - fixes cross account dynamic provisioning #1256
Conversation
Hi @RyanStan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
4e121a2
to
43d8f3c
Compare
For cross account provisioning, the controller pods need to be able to describe the x-account K8s Secret in the kube-system namespace. Additionally, I modified the IAM Role used in our cross-account mount example. Users should use the managed AmazonEFSCSIDriverPolicy, which I've copied here. Eventually, we will update the documentation to reference the managed policy instead of this file.
43d8f3c
to
cc355e1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, RyanStan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For cross account provisioning, the controller pods need to be able to describe K8s Secrets in the kube-system namespace.
Additionally, I modified the IAM Role used in our cross-account mount example. Users should use the managed AmazonEFSCSIDriverPolicy, which I've copied into describe-mount-target-example.json to be compatible with existing documentation links. Eventually, we will update the documentation to point at the managed policy instead of this file.
Why did I change that IAM Policy?
The describe-mount-target IAM Role wasn't working when following this blog post:
https://aws.amazon.com/blogs/storage/mount-amazon-efs-file-systems-cross-account-from-amazon-eks/
That's because it was missing two key permissions:
elasticfilesystem:TagResource
andelasticfilesystem:DescribeAccessPoints
Testing:
I performed a Helm installation and a kustomize installation of the driver. For each, I then performed a cross-account mount and ensured it was successful.