Build and push every master commit to master tag #215
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
||
| echo "Deploying driver" | ||
| sed -i'' "s,amazon/aws-efs-csi-driver,$IMAGE_NAME," deploy/kubernetes/overlays/dev/kustomization.yaml |
There was a problem hiding this comment.
This script doesn't seem to be used anywhere.
There was a problem hiding this comment.
You're right, I did a grep of latest and made changes everywhere. Technically someone could still use it (instead of using https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/tester/e2e-test-config.yaml which requires the k8stester binary), but probably we should remove it so we don't have to maintain it.
|
/lgtm |
|
@jqmichael: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -42,7 +42,7 @@ The following sections are Kubernetes specific. If you are a Kubernetes user, us | |||
| ### Container Images | |||
| |EFS CSI Driver Version | Image | | |||
| |---------------------------|-------------------------------------| | |||
| |master branch |amazon/aws-efs-csi-driver:latest | | |||
| |master branch |amazon/aws-efs-csi-driver:master | | |||
There was a problem hiding this comment.
Out of scope of this PR, but I think we should discourage users from using the latest/"master" tag by not mentioning it anywhere in the README. If users find it by reading the code, that's OK. But that doesn't apply to the majority of the users.
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
|
@jqmichael: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it? dev overlay still points to tag latest but we stopped pushing to tag latest. So the dev overlay is out of sync with the image. To put it back in sync, use tag
master.What testing is done? N/A