-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken import vbom.ml/util with github.com/fvbommel/util #251
Conversation
Hi @kbasv. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Appreciate jumping on this
@@ -1,3 +1,6 @@ | |||
*.swp | |||
bin/ | |||
vendor/ | |||
*.DS_Store | |||
*.idea | |||
test/e2e/results/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you prepend this with /
so that it's clear only the root folder is filtered not ./abc/test/e2e/results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intended to filter ./test/e2e/results - this folder contains the results of e2e tests in a file format. If we want do not want to filter the ./test/e2e/results, I can remove it.
/lgtm |
@jqmichael: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbasv, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Bug Fix
What is this PR about? / Why do we need it?
Docker build fails at
go mod download
step with the following message:Issue is same as kubernetes/kubectl#925.
What testing is done?
Tested locally and docker build succeeds