Add iam mount option while deleting Access Point root directory

[kbasv]

Is this a bug fix or adding new feature?
Fixes #419

What is this PR about? / Why do we need it?
Adds iam to controller mount option. iam ensures mounts for file systems with non anonymous principles to succeed.

What testing is done?
Tested on my cluster

[k8s-ci-robot]

Hi @kbasv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

/ok-to-test

I dont fully understand the issue. If we add iam, and mount.efs fails to find creds, the mount will fail. Why does it need creds?

[wongma7]

I guess a better question is why node mount command doesnt need the iam option? or, it might, but at least the user can supply it?

[kbasv]

@wongma7 EFS allows user to define file system policy to prevent anonymous access. In such cases, client has to authenticate, otherwise file system access will be denied.

For the node mount, user can supply iam option under volume mount options. Additionally, the user has to ensure efs-plugin running on the node has credentials required to authenticate either through IRSA or other mechanisms.

[wongma7]

OK. I think i understand now. if anonymous access is allowed, but we supply the iam mount option anyway, the mount wil lstill succeed because the controller must have iam cresd somewhre (even if it doesn't actually need them to do the mount)

[wongma7]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbasv, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment