-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.3.5 #601
Release v1.3.5 #601
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,8 +1,11 @@ | |||
# Helm chart | |||
|
|||
# v2.2.1 | |||
# master (unreleased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflict had to be resolved here.
for the efs repo, unlike fsx and ebs, the helm canonical source of helm chart is the release branch. So if a helm chart is edited in master branch it isn't actually released unless the change is backported to the release branch. In separate PRs, I'll backport the "Add controller.volMetricsOptIn for emitting volume metrics" change to release branch and then reconcile release and master branch.
The reason for this is because I found during dynamic provisioning release there was a long time between when helm chart was changed and when we could actually release it so it made sense to branch the helm chart to keep it isolated from master branch. Not sure if it's worth continuing this pattern though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold |
/lgtm |
/hold cancel |
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it? merging #599 and #600 back into master branch following https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/RELEASE.md#merge-the-release-and-post-release-commits-to-the-main-branch
What testing is done?