Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated NodeSelector #743

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Update deprecated NodeSelector #743

merged 1 commit into from
Oct 24, 2022

Conversation

dschunack
Copy link
Contributor

@dschunack dschunack commented Jul 26, 2022 •
edited
Loading

Signed-off-by: dschunack [email protected]

Is this a bug fix or adding new feature?

No, it replaced the deprecated NodeSelector labels #741

What is this PR about? / Why do we need it?
It replaced the deprecated NodeSelector labels #741

What testing is done?
helm chart was applied on a test EKS

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @dschunack!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dschunack. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2022
@dschunack
Copy link
Contributor Author

Hey @Ashley-wenyizha @justinsb, this is only a small PR to replace deprecated NodeSelectors. Would be nice, if you Approve the PR.

@dschunack
Copy link
Contributor Author

Kindly ping @Ashley-wenyizha @wongma7 @justinsb 🙂

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 25, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 28, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022
@dschunack
Copy link
Contributor Author

/assign @jsafrane

@jsafrane
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2022
@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dschunack, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit e7f647f into kubernetes-sigs:master Oct 24, 2022
@dschunack dschunack deleted the improvement/node-selector branch October 24, 2022 14:19
Ashley-wenyizha
Ashley-wenyizha reviewed Nov 1, 2022
View reviewed changes
charts/aws-efs-csi-driver/Chart.yaml
@@ -1,7 +1,7 @@
apiVersion: v2
name: aws-efs-csi-driver
version: 2.2.9
appVersion: 1.4.2
Copy link
Contributor

@Ashley-wenyizha Ashley-wenyizha Nov 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing here before a new release?

@Ashley-wenyizha Ashley-wenyizha mentioned this pull request Nov 1, 2022
Merged
Ashley-wenyizha added a commit to Ashley-wenyizha/aws-efs-csi-driver that referenced this pull request Nov 1, 2022
@Ashley-wenyizha
Add kubernetes-sigs#743 to changelog
88d6b72
@Ashley-wenyizha Ashley-wenyizha mentioned this pull request Nov 1, 2022
Merged
Ashley-wenyizha added a commit that referenced this pull request Nov 1, 2022
@Ashley-wenyizha
Merge pull request #805 from Ashley-wenyizha/release-1.4
235d769 
Add #743 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashley-wenyizha Ashley-wenyizha Ashley-wenyizha left review comments

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dschunack @k8s-ci-robot @jsafrane @Ashley-wenyizha