feat: add TCPRoute controller #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
force-pushed
the
shaneutt/tcproute-controller
branch
from
e6ebbcb
to
8f70006
Compare
shaneutt
added
the
do-not-merge
|
added |
mlavacca
previously approved these changes
Dec 21, 2022
mlavacca
previously approved these changes
Dec 21, 2022
mlavacca
approved these changes
Dec 21, 2022
astoycos
reviewed
Dec 21, 2022
astoycos
reviewed
Dec 21, 2022
astoycos
approved these changes
Dec 21, 2022
This enables debugging, such as using tcpdump inside the running container.
Pinning to version so that we can deliberately upgrade going forward, making tests more predictable.
shaneutt
force-pushed
the
shaneutt/tcproute-controller
branch
from
8c7f77d
to
fda9596
Compare
|
Re-based, ready to merge 👍 |
shaneutt
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily adds the
TCPRoutecontroller and samples. Note however that the dataplane does not have complete TCP support yet (though some scaffolding for it is added as of this PR) so the dataplane configuration produced is valid but the samples wont work yet. This scaffolding however will help to support #45 and #15 which are responsible for completing this.Resolves #16
This also includes some refactoring and cleanup, notably it refactors the dataplane code into modules.