Refactor | logging for src ip

[rushi47]

Fixes : #71

Replace custom function with formatter from aaya itself.

[shaneutt]

Couple small comments to resolve before we merge, but overall looks good thanks @rushi47!

Wish I had known that you could use {:ipv4} some time back, that's terribly convenient 😂

[rushi47]

Integration tests are failing because :
Well interesting enough, same {:ipv4} formatter is behaving differently for icmp. Basically its loosing 2 values in last octect of ip address. Ex. instead of printing 172.0.2.100 its printing 172.0.2.1. I am trying to figure out whats the issue.

[shaneutt]

Integration tests are failing because : Well interesting enough, same {:ipv4} formatter is behaving differently for icmp. Basically its loosing 2 values in last octect of ip address. Ex. instead of printing 172.0.2.100 its printing 172.0.2.1. I am trying to figure out whats the issue.

Sounds good thanks for looking into it @rushi47. If it ends up looking like there's something wrong on the aya-log side, would definitely encourage you to submit an issue there (https://github.com/aya-rs/aya/issues/new). They also have a discord server which is active and helpful as well. Let us know if you get stuck, and how we can help you!

[rushi47]

Integration tests are failing because : Well interesting enough, same {:ipv4} formatter is behaving differently for icmp. Basically its loosing 2 values in last octect of ip address. Ex. instead of printing 172.0.2.100 its printing 172.0.2.1. I am trying to figure out whats the issue.

Sounds good thanks for looking into it @rushi47. If it ends up looking like there's something wrong on the aya-log side, would definitely encourage you to submit an issue there (https://github.com/aya-rs/aya/issues/new). They also have a discord server which is active and helpful as well. Let us know if you get stuck, and how we can help you!

Thank you @shaneutt, i was looking at code for aya log yesterday for formatter and tried to test it, with what they do internally it looked fine. But yes if this doesn't work I will raise issue.

[rushi47]

Well @shaneutt I reverted my commit and looked at main branch. The behavior is actually same for the main commit as well. And looks like that its not actually missing 00s but what its essentially doing i guess is returning the Gateway Ip of my network. So we can confirm that formatter is working fine. However,I need to check, how egress is called to make sure that port is unreachable in ingress udp path and debug from there.

[shaneutt]

Ok thanks @rushi47

Seems reasonable to get this merged for now, appreciate the contribution!

[shaneutt]

One last thing, @rushi47 we are configured to required signed commits, if you could please rebase and sign your commits we can then merge. Here's a help doc if needed: https://docs.github.com/articles/about-gpg/

[rushi47]

One last thing, @rushi47 we are configured to required signed commits, if you could please rebase and sign your commits we can then merge. Here's a help doc if needed: https://docs.github.com/articles/about-gpg/

Done @shaneutt I rebased and pushed again. Looks like our co-authered commits are unable to be verified. When I however it shows verified for me. Please lmk if anything else is needed.