Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate msi/subnet client to track2 one #1588

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Chores: remove subscriptionID from roledefinitionclient.New
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
- name: Set up Go 1.x
uses: actions/setup-go@v5
with:
go-version: ^1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-version: 1.23.1 may work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. codeql is built with 1.22. It doesn't support go 1.23.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinForReal
Copy link
Contributor Author

related: github/codeql#17443

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2024
@MartinForReal MartinForReal changed the title Chores: remove subscriptionID from roledefinitionclient.New Migrate msi/subnet client to track2 one Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@MartinForReal
Copy link
Contributor Author

/retest

@andyzhangx
Copy link
Member

nfs volume e2e tests failed due to this error:

[pod/csi-blob-controller-6958bcc45f-9hzcv/blob] I0923 13:58:03.269068       1 utils.go:104] GRPC call: /csi.v1.Controller/CreateVolume
[pod/csi-blob-controller-6958bcc45f-9hzcv/blob] I0923 13:58:03.269091       1 utils.go:105] GRPC request: {"capacity_range":{"required_bytes":10737418240},"name":"pvc-898b3ca8-9218-4c73-a1f7-74224eed16a1","parameters":{"csi.storage.k8s.io/pv/name":"pvc-898b3ca8-9218-4c73-a1f7-74224eed16a1","csi.storage.k8s.io/pvc/name":"pvc-n2kjm","csi.storage.k8s.io/pvc/namespace":"blob-3211","mountPermissions":"0755","protocol":"nfs","skuName":"Premium_LRS"},"volume_capabilities":[{"AccessType":{"Mount":{"mount_flags":["nconnect=8"]}},"access_mode":{"mode":5}}]}
[pod/csi-blob-controller-6958bcc45f-9hzcv/blob] E0923 13:58:03.269798       1 utils.go:109] GRPC error: rpc error: code = Internal desc = update service endpoints failed with error: networkClientFactory is nil

@cvvz
Copy link
Member

cvvz commented Sep 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cvvz, feiskyer, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit bc94800 into kubernetes-sigs:master Sep 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants