-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate msi/subnet client to track2 one #1588
Conversation
8e6e889
to
bc25578
Compare
bc25578
to
a3a0e70
Compare
a602527
to
e56facd
Compare
- name: Set up Go 1.x | ||
uses: actions/setup-go@v5 | ||
with: | ||
go-version: ^1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go-version: 1.23.1
may work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. codeql is built with 1.22. It doesn't support go 1.23.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but codeql is still failing: https://github.com/kubernetes-sigs/blob-csi-driver/actions/runs/10797718254/job/29949578807?pr=1588
related: github/codeql#17443 |
bfb20cc
to
0c71b02
Compare
e32be33
to
c046d86
Compare
c046d86
to
0d3304d
Compare
0d3304d
to
0591ff7
Compare
0591ff7
to
5421064
Compare
2d98c69
to
f34c3ec
Compare
/retest |
nfs volume e2e tests failed due to this error:
|
f34c3ec
to
2a1fa1a
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cvvz, feiskyer, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Chores: remove subscriptionID from roledefinitionclient.New
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: