Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blobfuse proxy #356

Merged
merged 3 commits into from
Mar 4, 2021
Merged

feat: blobfuse proxy #356

merged 3 commits into from
Mar 4, 2021

Conversation

boddumanohar
Copy link
Contributor

As a part of #349 I have created a POC of how we can make use of blobfuse-proxy to better manage FUSE mounts. Since its a huge PR, we are planning to split it up into multiple PRs.

As a part of this PR, I am submitted the code that is related to blobfuse proxy.

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: #115

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2021
@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 1, 2021
andyzhangx
andyzhangx reviewed Mar 1, 2021
View reviewed changes
Makefile
@@ -147,3 +147,33 @@ create-metrics-svc:
.PHONY: delete-metrics-svc
delete-metrics-svc:
kubectl delete -f deploy/example/metrics/csi-blob-controller-svc.yaml --ignore-not-found

# compile .proto file to go output
.PHONY: gen-proto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for dev purpose, is it possible to put it in Readme under blobfuse-proxy dir?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for:

  • clean-proto

andyzhangx
andyzhangx reviewed Mar 1, 2021
View reviewed changes
pkg/blobfuse-proxy/main.go Outdated
}

// MountAzureBlob mounts an azure blob container to given location
func (server *MountServer) MountAzureBlob(ctx context.Context,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is ut coverage, that would be better, thanks.

@boddumanohar
Copy link
Contributor Author

/test pull-blob-csi-driver-e2e

@boddumanohar boddumanohar force-pushed the blobfuse-proxy-code branch 4 times, most recently from e46a3a0 to 92e30ba Compare March 2, 2021 09:02
@andyzhangx andyzhangx changed the title submit blobfuse proxy code feat: blobfuse proxy code Mar 4, 2021
@andyzhangx andyzhangx changed the title feat: blobfuse proxy code feat: blobfuse proxy Mar 4, 2021
andyzhangx
andyzhangx approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7241cc7 into kubernetes-sigs:master Mar 4, 2021
@boddumanohar boddumanohar mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boddumanohar @k8s-ci-robot @andyzhangx