Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail blobfuse-proxy logs at the start of blobfuse-proxy daemonset #400

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

boddumanohar
Copy link
Contributor

What type of PR is this?
tail blobfuse-proxy logs at the start of blobfuse-proxy daemonset

/kind cleanup

What this PR does / why we need it: #392

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2021
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
echo "sleeping for 19 years"
sleep 600000000s
echo "sleeping for 10 secs"
sleep 10s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that means it can only get logs in the exact time of after 10s, is there better way to get all logs after all tests completed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is getting all the logs. In the above case, the sleep is to wait for the blobfuse-proxy service to come up. Although it happens much quicker than that.

@andyzhangx
Copy link
Member

should filter out AZURE_STORAGE_ACCESS_KEY in blobfuse-proxy logging and better keep other fields in the logs:

received auth env [AZURE_STORAGE_ACCESS_KEY=xxx AZURE_STORAGE_ACCOUNT=fusecd9d3dacdfc94335852 

@boddumanohar
Copy link
Contributor Author

@andyzhangx The .deb file present in the master is a little old. So I updated it with the latest one. Now we can observe we are not leaking secrets in the logs.

also, the current method we are using to distribute the .deb file is a little tedious. Because if someone made changes to the blobfuse-proxy then they have to build the new .deb themselves and update the links in deploy/blobfuse-proxy/blobfuse-proxy.yaml. And there is no way to guarantee its if the .deb file is legit. Instead its better if we have some automation around this.

@@ -44,7 +44,7 @@ spec:
apt-get update
apt-get install -y blobfuse=1.3.6
# download blobfuse-proxy .deb package
wget https://github.com/kubernetes-sigs/blob-csi-driver/raw/master/deploy/blobfuse-proxy/v0.1.0/blobfuse-proxy-v0.1.0.deb -O /tmp/blobfuse-proxy-v0.1.0.deb
wget https://github.com/boddumanohar/blob-csi-driver/raw/issues/392/deploy/blobfuse-proxy/v0.1.0/blobfuse-proxy-v0.1.0.deb -O /tmp/blobfuse-proxy-v0.1.0.deb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of creating a separate PR to to change: boddumanohar --> kubernetes-sigs . Can I update it right now? So that when the PR is merged, it will point to the correct file itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@andyzhangx
Copy link
Member

@andyzhangx The .deb file present in the master is a little old. So I updated it with the latest one. Now we can observe we are not leaking secrets in the logs.

also, the current method we are using to distribute the .deb file is a little tedious. Because if someone made changes to the blobfuse-proxy then they have to build the new .deb themselves and update the links in deploy/blobfuse-proxy/blobfuse-proxy.yaml. And there is no way to guarantee its if the .deb file is legit. Instead its better if we have some automation around this.

@boddumanohar could add a verification script in hack/ folder, it could build deb file automatically and do md5sum check with existing one, if there is diff, then verification failed?

@boddumanohar
Copy link
Contributor Author

@andyzhangx do you want me to propose the changes discussed above in this PR itself or a new PR?

@andyzhangx
Copy link
Member

@andyzhangx do you want me to propose the changes discussed above in this PR itself or a new PR?

@boddumanohar new PR is ok

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit eeb77e7 into kubernetes-sigs:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants