Update gnostic dependency with gnostic-models #625

liangyuanpeng · 2023-07-20T05:44:08Z

[Umbrella Issue] Replace google/gnostic import with google/gnostic-models kubernetes/kubernetes#118340

This PR changed:

update go version to 1.20
bump k8s.io packages to v0.28.4
bump sigs.k8s.io/kustomize to v5.2.1
bump sigs.k8s.io/controller-runtime to v0.16.3
bump sigs.k8s.io/yaml to v1.4.0
migrate from google/gnostic to google/gnostic-models

k8s-ci-robot · 2023-07-20T05:44:16Z

Welcome @liangyuanpeng!

It looks like this is your first PR to kubernetes-sigs/cli-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-07-20T05:44:17Z

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

liangyuanpeng · 2023-07-20T05:44:25Z

go.mod

-	k8s.io/utils v0.0.0-20230115233650-391b47cb4029
-	sigs.k8s.io/controller-runtime v0.14.1
-	sigs.k8s.io/kustomize/kyaml v0.13.9
+	k8s.io/api v0.28.0-alpha.4


Now, i just use v0.28.0-alpha.4 to fix it, and i think we need to waiting for a stable version.

liangyuanpeng

Some api have changed, need update.

liangyuanpeng · 2023-08-17T10:38:38Z

cc @seans3 @Liujingfang1 @mortent @karlkfi

stefanprodan · 2023-11-13T15:21:06Z

@liangyuanpeng could you please revive this PR. We really need this merged to unblock the Flux upgrade to Kubernetes 1.28. Thank you!

ash2k · 2023-11-13T20:53:52Z

/ok-to-test

ash2k · 2023-11-24T21:20:38Z

/lgtm

@seans3 PTAL.

seans3

/lgtm

I believe you can even update to the latest v0.28.4 (instead of v0.28.0) if you prefer.

@karlkfi Is this update OK with you?

liangyuanpeng · 2023-11-27T08:31:47Z

@ash2k @seans3 Update to v0.28.4 and not v0.28.0, PTAL,Thanks!

ash2k · 2023-11-27T12:11:31Z

/lgtm

stefanprodan

To match Kubernetes 1.28 these could also be bumped:

	sigs.k8s.io/controller-runtime v0.16.3
	sigs.k8s.io/kustomize/kyaml v0.15.0
	sigs.k8s.io/yaml v1.4.0

For reference https://github.com/fluxcd/cli-utils/pull/1/files

liangyuanpeng · 2023-11-28T07:08:42Z

@stefanprodan Thanks for remind.
You are the end user and have already applied this change to fluxcd, so I followed your advice and updated. Since the CI is green without this change, it would be great if you could provide more information to increase the reviewer's confidence.

Sorry about duplicate lgtm.

go.mod

- bump k8s.io packages to v0.28.4 - bump sigs.k8s.io/kustomize to v5.2.1 - bump sigs.k8s.io/controller-runtime to v0.16.3 - bump sigs.k8s.io/yaml to v1.4.0 - migrate from google/gnostic to google/gnostic-models Signed-off-by: Lan Liang <[email protected]>

stefanprodan

LGTM

Thanks @liangyuanpeng

ash2k · 2023-11-28T10:46:05Z

/lgtm

ash2k · 2023-12-06T09:44:58Z

@seans3 @karlkfi I think this is ready for merging, PTAL.

mortent · 2024-01-03T00:24:09Z

/approve

k8s-ci-robot · 2024-01-03T00:24:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, mortent, stefanprodan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mortent]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liangyuanpeng · 2024-01-12T07:08:03Z

Thanks @mortent for approve and thanks @ash2k help to push it.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2023

k8s-ci-robot requested review from karlkfi and seans3 July 20, 2023 05:44

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2023

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 20, 2023

liangyuanpeng commented Jul 20, 2023

View reviewed changes

tjsampson mentioned this pull request Aug 3, 2023

cmd/go: go install cmd@version errors out when module with main package has replace directive golang/go#44840

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2023

liangyuanpeng force-pushed the gnostic-dependency branch from 69a887f to b92c45e Compare August 15, 2023 03:00

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2023

liangyuanpeng force-pushed the gnostic-dependency branch from b92c45e to 583bbd8 Compare August 17, 2023 10:37

stefanprodan mentioned this pull request Aug 22, 2023

Update Flux controllers to Kustomize v5.2 fluxcd/flux2#3991

Closed

5 tasks

stefanprodan mentioned this pull request Nov 13, 2023

[Umbrella Issue] Replace google/gnostic import with google/gnostic-models kubernetes/kubernetes#118340

Open

3 tasks

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2023

stefanprodan mentioned this pull request Nov 20, 2023

Update to Kubernetes v1.28.4 fluxcd/cli-utils#1

Merged

k8s-ci-robot assigned ash2k Nov 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2023

seans3 reviewed Nov 27, 2023

View reviewed changes

k8s-ci-robot assigned seans3 Nov 27, 2023

liangyuanpeng force-pushed the gnostic-dependency branch from 583bbd8 to e01c587 Compare November 27, 2023 08:29

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023

stefanprodan reviewed Nov 27, 2023

View reviewed changes

liangyuanpeng force-pushed the gnostic-dependency branch from e01c587 to cb07b5f Compare November 28, 2023 07:06

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023

liangyuanpeng force-pushed the gnostic-dependency branch from cb07b5f to 9daef1f Compare November 28, 2023 07:12

stefanprodan reviewed Nov 28, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

liangyuanpeng force-pushed the gnostic-dependency branch from 9daef1f to 6bdf5b5 Compare November 28, 2023 09:13

stefanprodan approved these changes Nov 28, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023

ash2k mentioned this pull request Dec 24, 2023

Archive the repository? #636

Closed

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024

k8s-ci-robot merged commit 7928dbf into kubernetes-sigs:master Jan 3, 2024
5 checks passed

liangyuanpeng deleted the gnostic-dependency branch January 12, 2024 07:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gnostic dependency with gnostic-models #625

Update gnostic dependency with gnostic-models #625

liangyuanpeng commented Jul 20, 2023 •

edited

Loading

k8s-ci-robot commented Jul 20, 2023

k8s-ci-robot commented Jul 20, 2023

liangyuanpeng Jul 20, 2023

liangyuanpeng left a comment

liangyuanpeng commented Aug 17, 2023

stefanprodan commented Nov 13, 2023

ash2k commented Nov 13, 2023

ash2k commented Nov 24, 2023

seans3 left a comment

liangyuanpeng commented Nov 27, 2023 •

edited

Loading

ash2k commented Nov 27, 2023

stefanprodan left a comment

liangyuanpeng commented Nov 28, 2023

stefanprodan left a comment

ash2k commented Nov 28, 2023

ash2k commented Dec 6, 2023

mortent commented Jan 3, 2024

k8s-ci-robot commented Jan 3, 2024

liangyuanpeng commented Jan 12, 2024

Update gnostic dependency with gnostic-models #625

Update gnostic dependency with gnostic-models #625

Conversation

liangyuanpeng commented Jul 20, 2023 • edited Loading

k8s-ci-robot commented Jul 20, 2023

k8s-ci-robot commented Jul 20, 2023

liangyuanpeng Jul 20, 2023

Choose a reason for hiding this comment

liangyuanpeng left a comment

Choose a reason for hiding this comment

liangyuanpeng commented Aug 17, 2023

stefanprodan commented Nov 13, 2023

ash2k commented Nov 13, 2023

ash2k commented Nov 24, 2023

seans3 left a comment

Choose a reason for hiding this comment

liangyuanpeng commented Nov 27, 2023 • edited Loading

ash2k commented Nov 27, 2023

stefanprodan left a comment

Choose a reason for hiding this comment

liangyuanpeng commented Nov 28, 2023

stefanprodan left a comment

Choose a reason for hiding this comment

ash2k commented Nov 28, 2023

ash2k commented Dec 6, 2023

mortent commented Jan 3, 2024

k8s-ci-robot commented Jan 3, 2024

liangyuanpeng commented Jan 12, 2024

liangyuanpeng commented Jul 20, 2023 •

edited

Loading

liangyuanpeng commented Nov 27, 2023 •

edited

Loading