Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AKS BYO nodepool test spec #5153

Closed
1 task
mboersma opened this issue Sep 30, 2024 · 6 comments · Fixed by #5233
Closed
1 task

Enable AKS BYO nodepool test spec #5153

mboersma opened this issue Sep 30, 2024 · 6 comments · Fixed by #5233
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@mboersma
Copy link
Contributor

/kind cleanup

What needs cleanup:

The AKSBYONodeSpec was temporarily disabled in #5151, but should be restored when CAPZ reference image publishing catches up with AKS.

Describe the solution you'd like
[Description of how you would like the cleanup to be done.]

Files to change: 1

  • test/e2e/azure_test.go
    • 856-866

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 30, 2024
@mboersma mboersma added this to the v1.18 milestone Sep 30, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2024

This will involve reverting #5151 and its backports to release branches, so these three PRs in total:

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 1, 2024

This is fixed on main by #5167.

For the release branches, I'll make a change to the test to refer to the new images.

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 1, 2024

This should be fixed on the release branches by #5230 and its ensuing cherry-pick.

@nojnhuh nojnhuh linked a pull request Nov 1, 2024 that will close this issue
@nawazkh
Copy link
Member

nawazkh commented Nov 7, 2024

Hey @nojnhuh and @mboersma , should this issue be closed now ?

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 7, 2024

Hey @nojnhuh and @mboersma , should this issue be closed now ?

Yep, thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Closing this issue.

In response to this:

Hey @nojnhuh and @mboersma , should this issue be closed now ?

Yep, thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants