Updated nodelister_mock.go by adding an over-riding function

[abdurrehman107]

What type of PR is this?
/kind bug

What this PR does / why we need it:
I have added an over-riding funciton to the the nodelister_mock.go whcih I think will sort the specific use case for Jonathan.

I am not very sure whether my pull request meets the complete needs to the issue (#3663) raised by @Jont828 . I aplogise for sending this in late, I want to improve on this PR and I'd love feedback on this. Looking forward.

Which issue(s) this PR fixes:
Aims to fix #3663

Special notes for your reviewer:
I'm looking forward to feedback please, lemme know what I can improve on. I'd love to know what I can do right

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @razashahid107. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[willie-yao]

/ok-to-test

[willie-yao]

Hi @razashahid107, thanks for working on this issue! As a general rule of thumb, mock files shouldn't be modified manually. Instead, I think nodelister_mock.go is missing a corresponding doc.go file. An example of this can be found in the agentpools mock here: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/8e1c9aead5a0c7aa7da343331c82c00364a9b9fd/azure/services/agentpools/mock_agentpools/doc.go

[k8s-ci-robot]

@razashahid107: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-e2e	35d5d40	link	true	/test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-aks	35d5d40	link	true	/test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-ci-entrypoint	35d5d40	link	true	/test pull-cluster-api-provider-azure-ci-entrypoint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment