remove predefined availabilityZones from AKS e2e templates #5034
Conversation
k8s-ci-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9481ce1cf5843b725f6b29df631925218ddea8a4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.16 |
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5034 +/- ##
==========================================
- Coverage 51.13% 51.12% -0.01%
==========================================
Files 274 274
Lines 24657 24657
==========================================
- Hits 12609 12607 -2
- Misses 11261 11263 +2
Partials 787 787 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
| @@ -9,7 +9,5 @@ spec: | |||
| osDiskType: "Managed" | |||
| osDiskSizeGB: 30 | |||
| enableNodePublicIP: false | |||
| enableUltraSSD: true | |||
There was a problem hiding this comment.
Last test hit this:
Availability zone is required for UltraSSD setting.: PUT https://management.azure.com/subscriptions/===REDACTED===/resourceGroups/capz-e2e-462egg-cc/providers/Microsoft.ContainerService/managedClusters/capz-e2e-462egg-cc-8qc6s
--------------------------------------------------------------------------------
RESPONSE 400: 400 Bad Request
ERROR CODE: ErrorCodeEnableUltraSSD
--------------------------------------------------------------------------------
{
"code": "ErrorCodeEnableUltraSSD",
"details": null,
"message": "Availability zone is required for UltraSSD setting.",
"subcode": ""
}
--------------------------------------------------------------------------------
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 53fd1ef750604ce14746fa2c175e9e403d5ad58f
|
|
@nojnhuh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
#5026 Should resolve this with fewer template changes. /close |
|
@nojnhuh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind flake
What this PR does / why we need it:
This is a workaround for #5033 for the AKS e2e tests. Availability zones may dynamically have restrictions placed on them at a subscription level so we can't always depend on a specific set of zones to be available to all regions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: