Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add quick start guide for CAPN #58

Merged
merged 1 commit into from
May 18, 2021
Merged

doc: add quick start guide for CAPN #58

merged 1 commit into from
May 18, 2021

Conversation

charleszheng44
Copy link
Contributor

@charleszheng44 charleszheng44 commented May 18, 2021 •
edited by christopherhein
Loading

Closes #52

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2021
@charleszheng44
Copy link
Contributor Author

/assign @christopherhein @Fei-Guo

christopherhein
christopherhein reviewed May 18, 2021
View reviewed changes
Copy link
Member

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, couple nits and sp. One other thing what do you think about moving this to docs/README.md while you are at it so it loads first when you look at the docs folder in Github.

docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
docs/capn-tutorial.md Outdated Show resolved Hide resolved
@christopherhein
Copy link
Member

/lgtm
/approve

Nice work, looks great thank you for doing this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [charleszheng44,christopherhein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@charleszheng44 charleszheng44 changed the title [WIP] doc: add quick start guide for CAPN doc: add quick start guide for CAPN May 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1eb78b9 into kubernetes-sigs:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherhein christopherhein christopherhein left review comments

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@resouer resouer Awaiting requested review from resouer

Assignees

@christopherhein christopherhein

@Fei-Guo Fei-Guo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a tutorial for new CAPN users
4 participants
@charleszheng44 @christopherhein @k8s-ci-robot @Fei-Guo