🌱 VN Agent Healthz Checks #87
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
|
/assign @charleszheng44 @Fei-Guo |
| @@ -103,6 +104,8 @@ func Run(c *config.Config, serverOption *options.ServerOption, stopCh <-chan str | |||
| }, | |||
| } | |||
|
|
|||
| fmt.Printf(serverOption.ClientCAFile) | |||
There was a problem hiding this comment.
Why we wanna print out the client CA file?
There was a problem hiding this comment.
Doh, debugging lol, I will remove that.
|
The envTest fails. Looking at the log 2021-06-03T18:32:39.544Z INFO controllers.VirtualCluster.Native service already exist {"service": "apiserver-svc"} There is a 6 seconds gap between service log and creating secret log which looks weird. I only see one Get call in between from code which can be slow. We probably need to increase the timeout in envTest. |
christopherhein
force-pushed
the
vn-agent-health
branch
from
a68febc
to
dd2d4eb
Compare
Signed-off-by: Chris Hein <[email protected]>
christopherhein
force-pushed
the
vn-agent-health
branch
from
dd2d4eb
to
e898f9b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This add the ability to use vn-agent with a
kubeconfigspecified, which works for the Deployment style vs the DaemonSet mechanism as well this added a/healthzendpoint for better checking of it's availability.