-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade Golang CI & Fix Lint #90
🌱 Upgrade Golang CI & Fix Lint #90
Conversation
Signed-off-by: Chris Hein <[email protected]>
/kind cleanup |
/assign @Fei-Guo |
Signed-off-by: Chris Hein <[email protected]>
Signed-off-by: Chris Hein <[email protected]>
25cd7de
to
5deaa15
Compare
/assign @charleszheng44 |
Wow, there are a lot of minor grammar issues. The code looks much better. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charleszheng44, christopherhein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This upgrades golangci and cleans up a bunch of linting issues that came up from previously having false positives in the test suite.
Related
closes #80