-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Adopt metal-go #527
🏃 Adopt metal-go #527
Conversation
Welcome @ctreatma! |
8aaa3ef
to
0dc788e
Compare
0dd1f56
to
088e8bd
Compare
bf6831a
to
46d2667
Compare
As of August 2, 2023 I ran the full |
/hold Setting a hold to be sure we don't commit before all conversations are resolved. |
This updates CAPP to use metal-go for all Equinix Metal API interactions. Since metal-go does not support the `PACKNGO_DEBUG` environment variable for debugging, that behavior is introduced within CAPP for backwards compatibility.
As of August 2, 2023 this PR has been updated to a version of |
@displague just waiting for you to confirm your conversations are resolved. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ctreatma, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/lgtm |
What this PR does / why we need it:
This PR replaces
packngo
withmetal-go
for all interactions with the Equinix Metal API. Themetal-go
SDK is generated from the Equinix Metal API spec, and we will gradually replace all usage ofpackngo
withmetal-go
to streamline support.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #