Skip to content

Commit

Permalink
fix loopvar linter issue and usage of deprecated grpc function
Browse files Browse the repository at this point in the history
  • Loading branch information
chrischdi committed Jun 6, 2024
1 parent ad80008 commit c5497fc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion controlplane/kubeadm/internal/etcd/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ func NewClient(ctx context.Context, config ClientConfiguration) (*Client, error)
Endpoints: []string{config.Endpoint}, // NOTE: endpoint is used only as a host for certificate validation, the network connection is defined by DialOptions.
DialTimeout: config.DialTimeout,
DialOptions: []grpc.DialOption{
grpc.WithBlock(), // block until the underlying connection is up
grpc.WithContextDialer(dialer.DialContextWithAddr),
},
TLS: config.TLSConfig,
Expand Down
3 changes: 0 additions & 3 deletions internal/controllers/machinedeployment/mdutil/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,6 @@ func FindNewMachineSet(deployment *clusterv1.MachineDeployment, msList []*cluste
var matchingMachineSets []*clusterv1.MachineSet
var diffs []string
for _, ms := range msList {
ms := ms

equal, diff, err := EqualMachineTemplate(&ms.Spec.Template, &deployment.Spec.Template)
if err != nil {
return nil, "", errors.Wrapf(err, "failed to compare MachineDeployment spec template with MachineSet %s", ms.Name)
Expand Down Expand Up @@ -459,7 +457,6 @@ func FindNewMachineSet(deployment *clusterv1.MachineDeployment, msList []*cluste

// Pick the first matching MachineSet that has been created after RolloutAfter.
for _, ms := range matchingMachineSets {
ms := ms
if ms.CreationTimestamp.After(deployment.Spec.RolloutAfter.Time) {
return ms, "", nil
}
Expand Down
1 change: 0 additions & 1 deletion test/infrastructure/inmemory/pkg/server/mux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,6 @@ func TestAPI_PortForward(t *testing.T) {
DialTimeout: 2 * time.Second,

DialOptions: []grpc.DialOption{
grpc.WithBlock(), // block until the underlying connection is up
grpc.WithContextDialer(dialer2.DialContextWithAddr),
},
TLS: &tls.Config{
Expand Down

0 comments on commit c5497fc

Please sign in to comment.