Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variables overrides for control plane #10665

Closed
fabriziopandini opened this issue May 23, 2024 · 2 comments · Fixed by #10682
Closed

Allow variables overrides for control plane #10665

fabriziopandini opened this issue May 23, 2024 · 2 comments · Fixed by #10682
Assignees
Labels
area/clusterclass Issues or PRs related to clusterclass help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

What would you like to be added (User Story)?

As a user, I would like to set overrides for variables that apply to the control plane only

Detailed Description

Cluster topology allows defining a sort of hierarchical set of variables, where there are global variables and overrides for specific objects, like MP and MD.

We should introduce a similar concept for CP too, thus allowing use cases like e.g. I set the size of my machines with a global variable, but I override it for the CP to use different machines

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
/area clusterclass
/priority important-longterm
/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added (User Story)?

As a user, I would like to set overrides for variables that apply to the control plane only

Detailed Description

Cluster topology allows defining a sort of hierarchical set of variables, where there are global variables and overrides for specific objects, like MP and MD.

We should introduce a similar concept for CP too, thus allowing use cases like e.g. I set the size of my machines with a global variable, but I override it for the CP to use different machines

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
/area clusterclass
/priority important-longterm
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/clusterclass Issues or PRs related to clusterclass priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 23, 2024
@sbueringer
Copy link
Member

Makes sense!

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterclass Issues or PRs related to clusterclass help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants