Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e test framework] replace fmt.Println with writes to ginko's writer #2514

Closed
chuckha opened this issue Mar 3, 2020 · 1 comment · Fixed by #3065
Closed

[e2e test framework] replace fmt.Println with writes to ginko's writer #2514

chuckha opened this issue Mar 3, 2020 · 1 comment · Fixed by #3065
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@chuckha
Copy link
Contributor

chuckha commented Mar 3, 2020

Example: https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/control_plane.go#L102

These existed to help debug. I'm not sure they're ever displayed though. Either they should be removed or replaced with a log to ginkgo's writer.

Part of this issue is figuring out if it's too noisy with those logging to ginkgo's writer or if these errors actually provide value.

/kind bug
/help
/milestone Next
/priority important-longterm

@k8s-ci-robot
Copy link
Contributor

@chuckha:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Example: https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/control_plane.go#L102

These existed to help debug. I'm not sure they're ever displayed though. Either they should be removed or replaced with a log to ginkgo's writer.

Part of this issue is figuring out if it's too noisy with those logging to ginkgo's writer or if these errors actually provide value.

/kind bug
/help
/milestone Next
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the Next milestone Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 3, 2020
k8s-ci-robot added a commit that referenced this issue May 22, 2020
🏃 e2e: replace fmt.Println with writes to ginko's writer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants