🌱 Add MachinePools to handler and topology test #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterclass
willie-yao
force-pushed
the
handler-topology-tests
branch
from
9849703
to
d0af720
Compare
willie-yao
changed the title
willie-yao
force-pushed
the
handler-topology-tests
branch
from
d0af720
to
ec6cff1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c29e4cb6cb3aa64f96118da448a7479ef189f654
|
|
Thank you!! /approve Really appreciate your ongoing work on this!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
Not sure what that was: ∅ test/extension
∅ test/extension/handlers/lifecycle
✖ test/extension/handlers/topologymutation
=== Failed
=== FAIL: test/extension/handlers/topologymutation (0.00s)
FAIL sigs.k8s.io/cluster-api/test/extension/handlers/topologymutation [build failed]Let's see if it repeats |
|
@willie-yao Can you please look into it? I'm guessing some compile error in tests (potentially only reproducible locally after rebase onto main) |
willie-yao
force-pushed
the
handler-topology-tests
branch
from
ec6cff1
to
da1355d
Compare
k8s-ci-robot
removed
the
lgtm
|
@sbueringer Should be fixed now! |
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5aadfa98d957a8a4a5b10a33ca6c0469036bca20
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds MachinePools to the unit tests in
handler_test.goandtopology_test.go. This is a follow-up task to enabling MachinePools in ClusterClass.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #10028
/area clusterclass